JSONRPC request-response logging #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
ercecan,
eyusufatik,
jfldde,
kpp and
rakanalh
eyusufatik
approved these changes
Sep 27, 2024
kpp
approved these changes
Sep 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
|
we might want to delete enter traces to rpcs as well, I think there were some in ledger rpc, wdyt? |
jfldde
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added logging to each JSONRPC request and response to be able to have better debuggability of our nodes. Each request and successful response is logged with debug tracing level. Error responses are logged with warn level since it is highly likely that the error is caused by the client-side.
Original idea was to add a new tracing level for rpc request logging. But such behavior is not possible with tracing crate. Instead of that, errors are now logged to warn level, and can be searched with a filter such as level = WARN && message = rpc_error.
I initially logged the request and success responses to info level, but due to full nodes constantly spamming sequencer for new blocks through rpc, sequencer logs became full with useless rpc calls, which is not good. Another potential approach might be to make Sequencer RPC logs debug, but full node rpc logs info.
Also, prover doesn't have any rpc logs as it is unnecessary.
Linked Issues
Testing
I ran sequencer and full node and sent rpc requests and observed logs.